Skip to content

chore: Minor refactoring creating functions for transforming bytes #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

chore: Minor refactoring creating functions for transforming bytes #397

merged 2 commits into from
Jul 1, 2025

Conversation

allenporter
Copy link
Contributor

This is in preparation for sharin with new device/mqtt code.

@allenporter
chore: Minor refactoring creating functions for transforming bytes
ce00ad8 
This is in preparation for sharin with new device/mqtt code.
@allenporter allenporter requested a review from Lash-L June 29, 2025 20:59
Lash-L
Lash-L reviewed Jun 30, 2025
View reviewed changes
Lash-L
Lash-L approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I think this is a good code cleanup step - makes it a bit clearer to see what is happening opposed to the previous function calls

@allenporter allenporter merged commit b19dbaa into Python-roborock:main Jul 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lash-L Lash-L Lash-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allenporter @Lash-L